Skip to content

[Intl][String] Document emoji #17194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Aug 17, 2022

fixes #17191
fixes #17193

@carsonbot carsonbot added this to the 6.2 milestone Aug 17, 2022
@carsonbot carsonbot changed the title [String][Intl] Document emoji [Intl][String] Document emoji Aug 17, 2022
@OskarStark
Copy link
Contributor

Please add versionadded directives, thank you

Copy link
Member Author

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, I addressed your comments

@javiereguiluz javiereguiluz merged commit 2ec3735 into symfony:6.2 Aug 31, 2022
@javiereguiluz
Copy link
Member

Nice feature! Thanks Grégoire!

@lyrixx lyrixx deleted the translit-emoji branch September 1, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[String] Add support for emoji in AsciiSlugger [Intl] Update EmojiTransliterator to translate emoji to github and slac…
7 participants